Skip to content

Windows Menu Support #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Windows Menu Support #24

wants to merge 45 commits into from

Conversation

@SeanBarker182
Copy link
Contributor

@SeanBarker182 SeanBarker182 commented Sep 25, 2025 •
edited by jamonholmgren
Loading

Adds a menu to the Windows version of Reactotron.

Screen.Recording.2025-11-04.at.1.38.14.PM.mov

(Click to view screen recording.)

We went with a React Native menu system rather than native for flexibility; however, we may want to replace with a system menu in the future.

Here's a system menu as an example:

Windows system menu

For the future, we can possibly use GetSystemMenu and:

AppendMenuW(hMenu, MF_STRING, ID_MENU_ITEM, L"Menu Item");
InsertMenuW(hMenu, position, MF_BYPOSITION | MF_STRING, ID_MENU_ITEM, L"Item");
ModifyMenuW(hMenu, ID_MENU_ITEM, MF_BYCOMMAND | MF_STRING, ID_MENU_ITEM, L"New Text");
DeleteMenu(hMenu, ID_MENU_ITEM, MF_BYCOMMAND);

@SeanBarker182 SeanBarker182 marked this pull request as draft September 25, 2025 21:04
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 25, 2025
View reviewed changes
@SeanBarker182 SeanBarker182 changed the title WIP: Windows Menu Support Windows Menu Support Nov 4, 2025
@SeanBarker182 SeanBarker182 marked this pull request as ready for review November 4, 2025 19:09
jamonholmgren
jamonholmgren reviewed Nov 7, 2025
View reviewed changes
Copy link
Member

@jamonholmgren jamonholmgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to send these earlier this week ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenconner stevenconner Awaiting requested review from stevenconner

@jamonholmgren jamonholmgren Awaiting requested review from jamonholmgren

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SeanBarker182 @jamonholmgren